Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multi-Database Support] Without Reliance on boolean integer compare #4757

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

shoothzj
Copy link
Member

@shoothzj shoothzj commented Mar 1, 2023

What's the purpose of this PR

Comparing INTEGER type to BOOLEAN type is not supported by h2 database. We should avoid using this feature.

Tested on my laptop.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #4757 (00d9bf8) into master (a76521e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4757   +/-   ##
=========================================
  Coverage     47.27%   47.27%           
  Complexity     1655     1655           
=========================================
  Files           346      346           
  Lines         10662    10662           
  Branches       1058     1058           
=========================================
  Hits           5040     5040           
  Misses         5316     5316           
  Partials        306      306           
Impacted Files Coverage Δ
...m/ctrip/framework/apollo/biz/entity/AccessKey.java 58.33% <ø> (ø)
...a/com/ctrip/framework/apollo/biz/entity/Audit.java 52.94% <ø> (ø)
...com/ctrip/framework/apollo/biz/entity/Cluster.java 58.82% <ø> (ø)
.../com/ctrip/framework/apollo/biz/entity/Commit.java 5.55% <ø> (ø)
...p/framework/apollo/biz/entity/GrayReleaseRule.java 100.00% <ø> (ø)
...va/com/ctrip/framework/apollo/biz/entity/Item.java 86.36% <ø> (ø)
...m/ctrip/framework/apollo/biz/entity/Namespace.java 61.11% <ø> (ø)
...rip/framework/apollo/biz/entity/NamespaceLock.java 25.00% <ø> (ø)
...m/ctrip/framework/apollo/biz/entity/Privilege.java 8.33% <ø> (ø)
...com/ctrip/framework/apollo/biz/entity/Release.java 82.14% <ø> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 819014f into apolloconfig:master Mar 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2023
@shoothzj shoothzj deleted the avoid-boolean-integer2 branch March 2, 2023 00:02
@nobodyiam nobodyiam added this to the 2.2.0 milestone Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants