-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix apolloconfigdb.sql apolloportaldb.sql AppId length settings are inconsistent #4725
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4725 +/- ##
=========================================
Coverage 47.22% 47.22%
Complexity 1661 1661
=========================================
Files 349 349
Lines 10691 10691
Branches 1062 1062
=========================================
Hits 5049 5049
- Misses 5334 5335 +1
+ Partials 308 307 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I have updated the relevant question, please review it for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
When I initialized the database script, I found that the size of the
AppId
field in each table was inconsistent. I think it needs a uniform size of varchar 64.For example, AppId is the logical foreign key of the database table AppNamespace. The size of AppId needs to be consistent and should be set to 64. Why not 500? Because when I try to put the UNIQUE index on the AppId VARCHAR(500) field, it will prompt
the specified key was too long; max key length is 767 bytes
, in theutf8mb4
character set mode, the field length should be less than 191.And the front-end page design has made a check that the length cannot be greater than 64。
So I think the size of appId should be set to varchar 64.
According to the database script information, the database
App
table sets the size ofAppId
to500
.According to the database script information, the database
AppNamespace
table sets the size ofAppId
to64
.Brief changelog
Follow this checklist to help us incorporate your contribution quickly and easily:
CHANGES
log.