Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge the service registry delta sql to v200-v210 as 2.1.0 is not released #4653

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

merge the service registry delta sql to v200-v210 as 2.1.0 is not released

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…eased
@nobodyiam nobodyiam requested a review from Anilople November 20, 2022 13:02
@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Merging #4653 (1616590) into master (0cba6f6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4653   +/-   ##
=========================================
  Coverage     47.17%   47.17%           
  Complexity     1650     1650           
=========================================
  Files           347      347           
  Lines         10643    10643           
  Branches       1057     1057           
=========================================
  Hits           5021     5021           
  Misses         5318     5318           
  Partials        304      304           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Anilople
Copy link
Contributor

mark #4595

Copy link
Contributor

@Anilople Anilople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anilople Anilople merged commit 28df335 into apolloconfig:master Nov 21, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2022
@nobodyiam nobodyiam deleted the fix-delta-sql branch November 22, 2022 00:25
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants