Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Simplified the Env class in apollo-portal that links to Env enum in apollo-core #4011

Merged
merged 5 commits into from
Oct 8, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Simplified the Env class that links to Env enum
Since the Env class in portal/environment is a class representation of
the enum Env in the apollo core project I linked them better together.
This means if important changes happen in the enum it is automatically
reflected to the class representation.

Additionall I simplified the `transformEnv` method inside the Env class.
The switch will be never reached since all those values are already
matched in the `Env.valueOf(envName)`.

Further more I added more javadoc and tests to boost up the coverage
DiegoKrupitza committed Oct 1, 2021

Verified

This commit was signed with the committer’s verified signature. The key has expired.
jeff-mccoy Megamind
commit cf00fb5575ab552e62c59d8a9f6660ecdc76ddb5
Loading