add access control support for admin service #3233
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
Add access control support for admin service so that only trusted apollo portal could access admin service.
Instructions
Configurations for admin service
The following configurations can be set in ApolloConfigDB.ServerConfig.
Specify whether to enable access control for admin service or not. If set to true, then portal must pass the correct token when calling admin service.
Specify the tokens allowed to call admin service, multiple tokens should be separated by
,
.If this configuration is empty, then the access control won't take effect.
Configurations for portal
The following configurations can be set in ApolloPortalDB.ServerConfig.
Specify the access tokens for admin service in different environments in json format, e.g.
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.