Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add APP_ID env. #2067

Merged
merged 4 commits into from
Mar 24, 2019
Merged

add APP_ID env. #2067

merged 4 commits into from
Mar 24, 2019

Conversation

JaredTan95
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 21, 2019

Codecov Report

Merging #2067 into master will increase coverage by <.01%.
The diff coverage is 20%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2067      +/-   ##
============================================
+ Coverage     49.96%   49.97%   +<.01%     
- Complexity     1978     1979       +1     
============================================
  Files           401      401              
  Lines         12406    12411       +5     
  Branches       1278     1279       +1     
============================================
+ Hits           6199     6202       +3     
- Misses         5748     5750       +2     
  Partials        459      459
Impacted Files Coverage Δ Complexity Δ
...internals/provider/DefaultApplicationProvider.java 65.95% <20%> (-5.48%) 11 <0> (ø)
.../apollo/internals/RemoteConfigLongPollService.java 80.36% <0%> (+1.22%) 28% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 553d781...b4b7795. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 21, 2019

Coverage Status

Coverage increased (+0.003%) to 53.67% when pulling b4b7795 on JaredTan95:apollo-id-env into 553d781 on ctripcorp:master.

@JaredTan95 JaredTan95 changed the title add APOLLO_APP_ID env. add APP_ID env. Mar 22, 2019
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 1668fa1 into apolloconfig:master Mar 24, 2019
CrackerCat pushed a commit to CrackerCat/apollo-1 that referenced this pull request Jul 31, 2024
support setting app id from OS environment variable APP_ID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants