Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #1880 pagination not work #1891

Merged
merged 7 commits into from
Jan 20, 2019
Merged

fixes #1880 pagination not work #1891

merged 7 commits into from
Jan 20, 2019
+62 −5

Conversation

kezhenxu94
Copy link
Member

Fixes #1880

@codecov-io
Copy link

codecov-io commented Jan 18, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@f99d54a). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1891   +/-   ##
=========================================
  Coverage          ?   50.21%           
  Complexity        ?     1926           
=========================================
  Files             ?      394           
  Lines             ?    12051           
  Branches          ?     1224           
=========================================
  Hits              ?     6052           
  Misses            ?     5545           
  Partials          ?      454
Impacted Files Coverage Δ Complexity Δ
.../framework/apollo/biz/service/InstanceService.java 77.27% <100%> (ø) 14 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f99d54a...98415fc. Read the comment docs.

nobodyiam
nobodyiam approved these changes Jan 20, 2019
View reviewed changes
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit db54e50 into apolloconfig:master Jan 20, 2019
@kezhenxu94 kezhenxu94 deleted the fix/1880 branch January 20, 2019 13:27
CrackerCat pushed a commit to CrackerCat/apollo-1 that referenced this pull request Jul 31, 2024
@kezhenxu94
fixes apolloconfig#1880 pagination not work (apolloconfig#1891)
ecff7d3 
fixes apolloconfig#1880 pagination not work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobodyiam nobodyiam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kezhenxu94 @codecov-io @nobodyiam