Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to override meta server url through environment variables. #1565

Merged
merged 1 commit into from
Oct 14, 2018
Merged

Support to override meta server url through environment variables. #1565

merged 1 commit into from
Oct 14, 2018

Conversation

JaredTan95
Copy link
Member

and squashed commits.

commit 49a8bd8
Merge: 2118488 e34cdce
Author: JaredTan95 <[email protected]>
Date:   Sun Oct 14 12:33:46 2018 +0800

    Merge branch 'master' of https://github.com/JaredTan95/apollo

commit 2118488
Author: nobodyiam <[email protected]>
Date:   Sat Oct 13 16:49:39 2018 +0800

    version to 1.1.1

    clean code.

    fix code style.

commit 9e32fcc
Author: JaredTan95 <[email protected]>
Date:   Sat Oct 13 14:51:20 2018 +0800

    Support to override meta server url through environment variables.

commit e34cdce
Author: JaredTan95 <[email protected]>
Date:   Sun Oct 14 09:35:35 2018 +0800

    fix code style.

commit 58e6fc7
Author: JaredTan95 <[email protected]>
Date:   Sat Oct 13 20:15:38 2018 +0800

    clean code.

commit a7fcbec
Merge: 15532fd c22ac56
Author: Jared.Tan <[email protected]>
Date:   Sat Oct 13 17:25:14 2018 +0800

    Merge branch 'master' into master

commit 15532fd
Author: JaredTan95 <[email protected]>
Date:   Sat Oct 13 17:23:27 2018 +0800

    refactoring legacy mete server and fix mistake in Dockerfile.

commit 3c9b00e
Author: JaredTan95 <[email protected]>
Date:   Sat Oct 13 16:37:04 2018 +0800

    modify Dockerfile Env `Version` to prevent duplicate changes and errors

commit 9ec44a8
Author: JaredTan95 <[email protected]>
Date:   Sat Oct 13 14:51:20 2018 +0800

    Support to override meta server url through environment variables.
@codecov-io
Copy link

codecov-io commented Oct 14, 2018

Codecov Report

Merging #1565 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1565      +/-   ##
============================================
- Coverage     48.62%   48.61%   -0.02%     
- Complexity     1896     1898       +2     
============================================
  Files           393      393              
  Lines         11495    11494       -1     
  Branches       1192     1194       +2     
============================================
- Hits           5590     5588       -2     
  Misses         5477     5477              
- Partials        428      429       +1
Impacted Files Coverage Δ Complexity Δ
...pollo/core/internals/LegacyMetaServerProvider.java 100% <100%> (ø) 9 <3> (+3) ⬆️
.../apollo/internals/RemoteConfigLongPollService.java 77.3% <0%> (-0.62%) 27% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3743d83...9f7a2a5. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 52.349% when pulling 9f7a2a5 on JaredTan95:legacy into 3743d83 on ctripcorp:master.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 39b36a0 into apolloconfig:master Oct 14, 2018
@JaredTan95 JaredTan95 deleted the legacy branch October 14, 2018 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants