Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize my-projects view to show projects which the user has admin permissions #1528

Merged
merged 1 commit into from
Oct 3, 2018

Conversation

nobodyiam
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 3, 2018

Codecov Report

Merging #1528 into master will increase coverage by 0.03%.
The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1528      +/-   ##
============================================
+ Coverage     48.88%   48.91%   +0.03%     
- Complexity     1891     1895       +4     
============================================
  Files           393      393              
  Lines         11414    11433      +19     
  Branches       1172     1176       +4     
============================================
+ Hits           5580     5593      +13     
- Misses         5406     5411       +5     
- Partials        428      429       +1
Impacted Files Coverage Δ Complexity Δ
...mework/apollo/portal/controller/AppController.java 18.98% <0%> (-1.85%) 3 <0> (ø)
...ip/framework/apollo/portal/service/AppService.java 3.27% <0%> (-0.06%) 2 <0> (ø)
.../spi/defaultimpl/DefaultRolePermissionService.java 68.69% <0%> (-3.13%) 24 <0> (ø)
.../ctrip/framework/apollo/portal/util/RoleUtils.java 71.42% <83.33%> (+4.76%) 12 <2> (+2) ⬆️
.../apollo/internals/RemoteConfigLongPollService.java 77.3% <0%> (+0.61%) 27% <0%> (ø) ⬇️
...lo/configservice/util/InstanceConfigAuditUtil.java 77.19% <0%> (+1.75%) 15% <0%> (ø) ⬇️
...work/apollo/biz/message/DatabaseMessageSender.java 66.66% <0%> (+10.41%) 8% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8b82d1...b80ac46. Read the comment docs.

@nobodyiam nobodyiam merged commit b70060f into apolloconfig:master Oct 3, 2018
@nobodyiam nobodyiam mentioned this pull request Oct 4, 2018
@nobodyiam nobodyiam changed the title optimize my-projects view to show projets which the user has admin permissions optimize my-projects view to show projects which the user has admin permissions Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants