Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增加 kubernetes 支持 #1416

Merged
merged 1 commit into from
Aug 30, 2018
Merged

增加 kubernetes 支持 #1416

merged 1 commit into from
Aug 30, 2018

Conversation

aiotceo
Copy link
Contributor

@aiotceo aiotceo commented Aug 29, 2018

一、增加 apollo on kubernetes 支持

二、修改 apollo-portal/src/main/docker/Dockerfile EXPOSE 端口为 8070

@codecov-io
Copy link

codecov-io commented Aug 29, 2018

Codecov Report

Merging #1416 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1416      +/-   ##
============================================
- Coverage     48.45%   48.41%   -0.04%     
+ Complexity     1797     1796       -1     
============================================
  Files           379      379              
  Lines         10914    10914              
  Branches       1115     1115              
============================================
- Hits           5288     5284       -4     
- Misses         5241     5246       +5     
+ Partials        385      384       -1
Impacted Files Coverage Δ Complexity Δ
...work/apollo/biz/message/DatabaseMessageSender.java 56.25% <0%> (-10.42%) 6% <0%> (-2%)
.../apollo/internals/RemoteConfigLongPollService.java 77.91% <0%> (+0.61%) 28% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7545bd3...49906bc. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 51.933% when pulling 49906bc on AiotCEO:kubernetes into 7545bd3 on ctripcorp:master.

@nobodyiam
Copy link
Member

非常感谢!

是否可以简单写一个使用说明以便其他用户参考?

@aiotceo
Copy link
Contributor Author

aiotceo commented Aug 29, 2018

@nobodyiam readme.md 写了使用说明,yaml 文件注释也写了使用说明

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 1e5a919 into apolloconfig:master Aug 30, 2018
@aiotceo aiotceo deleted the kubernetes branch August 31, 2018 05:13
Copy link

@vsxen vsxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tail tail /tmp/apollo-configservice_apollo-config-server.log 或者 类似Tomcat的CMD ["catalina.sh", "run"]

exit $rc;
fi

tail -f /dev/null
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个需要改一下吧 即使JAVA进程挂了或者没启动成功 这tail永远不会退出

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有啥好的建议吗?

Copy link

@vsxen vsxen Sep 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先看下作者的回复吧,可能作者有别的目的

我的建议是tail tail /tmp/apollo*.log 这样也方便分析日志

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants