-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
增加 kubernetes 支持 #1416
增加 kubernetes 支持 #1416
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1416 +/- ##
============================================
- Coverage 48.45% 48.41% -0.04%
+ Complexity 1797 1796 -1
============================================
Files 379 379
Lines 10914 10914
Branches 1115 1115
============================================
- Hits 5288 5284 -4
- Misses 5241 5246 +5
+ Partials 385 384 -1
Continue to review full report at Codecov.
|
非常感谢! 是否可以简单写一个使用说明以便其他用户参考? |
@nobodyiam readme.md 写了使用说明,yaml 文件注释也写了使用说明 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
用tail tail /tmp/apollo-configservice_apollo-config-server.log
或者 类似Tomcat的CMD ["catalina.sh", "run"]
exit $rc; | ||
fi | ||
|
||
tail -f /dev/null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个需要改一下吧 即使JAVA进程挂了或者没启动成功 这tail
永远不会退出
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有啥好的建议吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
先看下作者的回复吧,可能作者有别的目的
我的建议是tail tail /tmp/apollo*.log
这样也方便分析日志
一、增加 apollo on kubernetes 支持
二、修改 apollo-portal/src/main/docker/Dockerfile EXPOSE 端口为 8070