-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
优化Properties#stringPropertyNames处理,jdk9以下版本此方法cpu消耗相对过高. #1072
Merged
+50
−1
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,8 @@ | |
import java.util.Calendar; | ||
import java.util.Date; | ||
import java.util.Properties; | ||
import java.util.Set; | ||
import java.util.Collections; | ||
import java.util.concurrent.TimeUnit; | ||
|
||
import org.junit.After; | ||
|
@@ -645,6 +647,39 @@ public void onChange(ConfigChangeEvent changeEvent) { | |
assertEquals(PropertyChangeType.ADDED, newKeyChange.getChangeType()); | ||
} | ||
|
||
@Test | ||
public void testGetPropertyNames() { | ||
String someKeyPrefix = "someKey"; | ||
String someValuePrefix = "someValue"; | ||
|
||
//set up config repo | ||
someProperties = new Properties(); | ||
for (int i = 0; i < 10; i++) { | ||
someProperties.setProperty(someKeyPrefix + i, someValuePrefix + i); | ||
} | ||
|
||
when(configRepository.getConfig()).thenReturn(someProperties); | ||
|
||
DefaultConfig defaultConfig = | ||
new DefaultConfig(someNamespace, configRepository); | ||
|
||
Set<String> propertyNames = defaultConfig.getPropertyNames(); | ||
|
||
assertEquals(10, propertyNames.size()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. assertEquals(someProperties.stringPropertyNames(), propertyNames) ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 已增加. |
||
assertEquals(someProperties.stringPropertyNames(), propertyNames); | ||
} | ||
|
||
@Test | ||
public void testGetPropertyNamesWithNullProp() { | ||
when(configRepository.getConfig()).thenReturn(null); | ||
|
||
DefaultConfig defaultConfig = | ||
new DefaultConfig(someNamespace, configRepository); | ||
|
||
Set<String> propertyNames = defaultConfig.getPropertyNames(); | ||
assertEquals(Collections.emptySet(), propertyNames); | ||
} | ||
|
||
private void checkDatePropertyWithFormat(Config config, Date expected, String propertyName, String format, Date | ||
defaultValue) { | ||
assertEquals(expected, config.getDateProperty(propertyName, format, defaultValue)); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这段代码虽然是从jdk9复制过来的,还是建议加一段UT来测试,以防后续被其它人改错逻辑。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok已增加.