clear http response inputstream and errorstream to reuse connection.

apolloconfig · Dec 4, 2017 · 8d31e51 · 8d31e51
1 parent c97d5bb
commit 8d31e51
Showing 1 changed file with 21 additions and 2 deletions.
diff --git a/apollo-client/src/main/java/com/ctrip/framework/apollo/util/http/HttpUtil.java b/apollo-client/src/main/java/com/ctrip/framework/apollo/util/http/HttpUtil.java
@@ -70,6 +70,7 @@ public T apply(String input) {
   private <T> HttpResponse<T> doGetWithSerializeFunction(HttpRequest httpRequest,
                                                          Function<String, T> serializeFunction) {
     InputStreamReader isr = null;
+    InputStreamReader esr = null;
     int statusCode;
     try {
       HttpURLConnection conn = (HttpURLConnection) new URL(httpRequest.getUrl()).openConnection();
@@ -92,27 +93,45 @@ private <T> HttpResponse<T> doGetWithSerializeFunction(HttpRequest httpRequest,
       conn.connect();
 
       statusCode = conn.getResponseCode();
+      try {
+        isr = new InputStreamReader(conn.getInputStream(), StandardCharsets.UTF_8);
+      } catch (Exception e) {
+        // ignore
+      }
+      try {
+        esr = new InputStreamReader(conn.getErrorStream(), StandardCharsets.UTF_8);
+      } catch (Exception e) {
+        // ignore
+      }
 
       if (statusCode == 200) {
-        isr = new InputStreamReader(conn.getInputStream(), StandardCharsets.UTF_8);
         String content = CharStreams.toString(isr);
         return new HttpResponse<>(statusCode, serializeFunction.apply(content));
       }
 
       if (statusCode == 304) {
         return new HttpResponse<>(statusCode, null);
       }
-
     } catch (Throwable ex) {
       throw new ApolloConfigException("Could not complete get operation", ex);
     } finally {
       if (isr != null) {
         try {
+          CharStreams.toString(isr);
           isr.close();
         } catch (IOException e) {
           // ignore
         }
       }
+
+      if (esr != null) {
+          try {
+              CharStreams.toString(esr);
+              esr.close();
+          } catch (Exception e) {
+              // ignore
+          }
+      }
     }
 
     throw new ApolloConfigStatusCodeException(statusCode,