Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ordered interface to MessageProducerManager and Injector SPI #15

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

Add Ordered interface to MessageProducerManager and Injector SPI

Which issue(s) this PR fixes:

Fixes apolloconfig/apollo#4699

Brief changelog

  • Add Ordered interface to MessageProducerManager and Injector SPI
  • Deprecate ServiceBootstrap.loadFirst method

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #15 (62412e1) into main (f34c30c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main      #15      +/-   ##
============================================
+ Coverage     68.24%   68.25%   +0.01%     
- Complexity     1177     1179       +2     
============================================
  Files           165      167       +2     
  Lines          5123     5125       +2     
  Branches        560      560              
============================================
+ Hits           3496     3498       +2     
  Misses         1365     1365              
  Partials        262      262              
Impacted Files Coverage Δ
...amework/foundation/internals/ServiceBootstrap.java 94.11% <ø> (ø)
...m/ctrip/framework/apollo/build/ApolloInjector.java 40.90% <100.00%> (ø)
...com/ctrip/framework/apollo/internals/Injector.java 100.00% <100.00%> (ø)
...java/com/ctrip/framework/apollo/tracer/Tracer.java 87.50% <100.00%> (ø)
...work/apollo/tracer/spi/MessageProducerManager.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nobodyiam nobodyiam requested a review from a team January 21, 2023 01:00
@nobodyiam nobodyiam merged commit 093e186 into main Jan 26, 2023
@nobodyiam nobodyiam deleted the ordered-interface branch January 26, 2023 00:35
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2023
@nobodyiam nobodyiam added this to the 2.1.0 milestone Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

格式解析报错了,捕获异常并发送第三方通知
1 participant