Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix flake #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Nix flake #1

wants to merge 2 commits into from

Conversation

VzxPLnHqr
Copy link

No description provided.

@apoelstra
Copy link
Owner

Thank you! I am not very familiar with flakes. This will be a good starting point for me to learn. I will try to study this this morning.

@VzxPLnHqr VzxPLnHqr force-pushed the nix-flake branch 3 times, most recently from ed899e7 to 30f3c98 Compare May 15, 2024 22:07
flake.nix Show resolved Hide resolved
README.md Show resolved Hide resolved
@apoelstra
Copy link
Owner

Tested 30f3c98 -- the README instructions do work. Very impressive. Also cool that the rust overlay is able to read our toolchain file (and I guess, this is why we need to use the overlay rather than just grabbing rustc from nixpkgs).

Disappointed that we need 3rd party dependencies to get lib.eachDefaultSystem but whatever, not gonna litigate that here..

I think if you can

  • Fix the two trailing whitespace things
  • Squash the "fix default package" commit into the first commit

Then I'd be happy to merge this!

@VzxPLnHqr
Copy link
Author

VzxPLnHqr commented Jun 12, 2024

My git skills are not the greatest. I did a git rebase -i main and chose "edit" on the first commit. However there was no trailing whitespace for me to remove in flake.nix so maybe that has already been fixed somehow by a prior force-push? However, I did remove the trailing whitespace in the README, and I squashed the "fix default package" commit (but possibly into the wrong parent), so there should only be two commits now: one with the code, and one for the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants