Skip to content

Commit

Permalink
Merge #20006: Fix misleading error message: Clean stack rule
Browse files Browse the repository at this point in the history
af57766 Fix misleading error message: Clean stack rule (sanket1729)

Pull request description:

  Error messages in clean stack is misleading as it lets the user believe that there are extra
  elements on the stack which is incorrect if the stack is empty.

  Let me know if this requires additional test.

ACKs for top commit:
  instagibbs:
    re-ACK bitcoin/bitcoin@af57766
  gzhao408:
    reACK bitcoin/bitcoin@af57766
  theStack:
    re-ACK af57766
  darosior:
    re ACK af57766

Tree-SHA512: 88e77416e220b080246fec368f5552a891d102d072b7bee62ac560d5e31c4a8c2ee9cbe569740b253e9df177d21dc788d10d856b2a542ab47761bb81698e4082
laanwj committed Sep 30, 2020
2 parents 5c435c7 + af57766 commit 4f5ae52
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/script/script_error.cpp
Original file line number Diff line number Diff line change
@@ -76,7 +76,7 @@ std::string ScriptErrorString(const ScriptError serror)
case SCRIPT_ERR_PUBKEYTYPE:
return "Public key is neither compressed or uncompressed";
case SCRIPT_ERR_CLEANSTACK:
return "Extra items left on stack after execution";
return "Stack size must be exactly one after execution";
case SCRIPT_ERR_WITNESS_PROGRAM_WRONG_LENGTH:
return "Witness program has incorrect length";
case SCRIPT_ERR_WITNESS_PROGRAM_WITNESS_EMPTY:

0 comments on commit 4f5ae52

Please sign in to comment.