This repository has been archived by the owner on Apr 17, 2021. It is now read-only.
Update lambdas for testing and include in test run #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
alistairjcbrown
force-pushed
the
update-lambda-testing
branch
from
44d15c8 to
e3e7479
Compare
alistairjcbrown
force-pushed
the
update-lambda-testing
branch
from
e3e7479 to
94d124b
Compare
alistairjcbrown
force-pushed
the
update-lambda-testing
branch
from
94d124b to
7d60e80
Compare
alistairjcbrown
force-pushed
the
update-lambda-testing
branch
from
7d60e80 to
e8f210a
Compare
alistairjcbrown
force-pushed
the
update-lambda-testing
branch
from
e8f210a to
92c80cb
Compare
|
I've trimmed this PR down to just the bare bones of introducing the testing setup and having it run on CI. The eventbrite lambda tests will be added in follow-up PRs for easier review. |
apoclyps
reviewed
Oct 27, 2018
| @@ -7,3 +7,7 @@ WORKDIR /lambdas-test/ | |||
| RUN npm install | |||
|
|
|||
| COPY . /lambdas-test/ | |||
|
|
|||
| RUN cd eventbrite && npm install | |||
There was a problem hiding this comment.
If the WORKDIR is set to /lambdas-test/ will each of these commands need to CD back up a level or is RUN always running from the work director?
There was a problem hiding this comment.
@apoclyps Yea, if I understand it correctly:
WORKDIR"sets the working directory" (https://docs.docker.com/engine/reference/builder/#workdir) that things likeRUNwill execute inRUNs are isolated (other than persisted side effects, eg. file system changes).
So everything should be within the lambdas-test directory, and every RUN will start from there and cd down.
alistairjcbrown
force-pushed
the
update-lambda-testing
branch
from
92c80cb to
73ab826
Compare
apoclyps
approved these changes
Oct 27, 2018
alistairjcbrown
force-pushed
the
update-lambda-testing
branch
from
eb97537 to
2a69034
Compare
|
Code Climate has analyzed commit 2a69034 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Add initial lambda tests and sets up the tooling to have these run as part of CI. All lambdas currently have only placeholder tests to confirm handler functions are exported.
Follow-up PRs will add lambda specific tests to cover implemented functionality.