This repository has been archived by the owner on Apr 17, 2021. It is now read-only.
Update lambdas for linting and include in test run #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistairjcbrown
force-pushed
the
update-lambda-linting
branch
from
cc53687 to
29709de
Compare
alistairjcbrown
changed the base branch from
implement-meetupcom-transformer
to
master
alistairjcbrown
force-pushed
the
update-lambda-linting
branch
from
29709de to
d792010
Compare
apoclyps
reviewed
Oct 21, 2018
apoclyps
reviewed
Oct 21, 2018
apoclyps
approved these changes
Oct 21, 2018
|
Code Climate has analyzed commit 1877841 and detected 0 issues on this pull request. View more on Code Climate. |
|
Thanks @apoclyps |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Linting tooling has been in place for the Node.js lambdas, but not been used. This PR runs
npm run lint -- --fixon the lambda JavaScript codebase (as well as some other small code adjustments and linting fixes), and also adds the linting task to the overall codebase test run to fail builds which don't conform to linting standards.