This repository has been archived by the owner on Apr 17, 2021. It is now read-only.
Update Farset Labs calendar lambda for fixes and readme updates #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -47,6 +47,15 @@ const transformEvent = function (defaults, { | |||
|
|
|||
| const isValidEvent = (event) => validate(event, eventSchema).errors.length === 0; | |||
|
|
|||
| const uploadData = function(bucketName, calendarData) { | |||
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
alistairjcbrown
force-pushed
the
farset-labs-calendar-lambda-corrections
branch
from
c77889b to
bfe6139
Compare
| @@ -47,6 +47,15 @@ const transformEvent = function (defaults, { | |||
|
|
|||
| const isValidEvent = (event) => validate(event, eventSchema).errors.length === 0; | |||
|
|
|||
| const uploadData = function(bucketName, calendarData) { | |||
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
|
Code Climate has analyzed commit bfe6139 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
uploadDatafrom the utils had neglected that it was used by the transformer - this adds it to the transformer file. It's the same as the one in the producer, but most likely the file paths for transformers will be updated independently, once a standard is decided upon.