Implement Eventbrite transformer #464
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| } | ||
| }; | ||
|
|
||
| const transformEvent = function (defaults, event) { |
There was a problem hiding this comment.
Function transformEvent has 50 lines of code (exceeds 25 allowed). Consider refactoring.
|
|
||
| const isValidEvent = (event) => validate(event, eventSchema).errors.length === 0; | ||
|
|
||
| const uploadData = function(bucketName, eventsPage) { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| })); | ||
|
|
||
| const { eventsBucket } = buckets(); | ||
| const filePaths = await Promise.all(await transformedFiles.map(async function (transformedFile) { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit 371cdd6 and detected 5 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
| @@ -110,7 +110,6 @@ | |||
| "required": [ | |||
| "name", | |||
| "address", | |||
| "city", | |||
There was a problem hiding this comment.
No longer considering city a required field for a venue (what if it's not in a city?)
There was a problem hiding this comment.
city as an optional field makes sense; we can always decorate this later from the address.
| @@ -0,0 +1,260 @@ | |||
| { | |||
There was a problem hiding this comment.
Carbon copy of the schema for the farset labs lambda - something to extract in the future.
What's Changed
Implements transformer for Eventbrite data, saving to the shared
muxer-transformed-eventsbucket.Examples of source data and transformed data: https://gist.github.com/alistairjcbrown/a93c15f65bc4b7fc52236c91506d1813
Brought up some questions to think about in the future: