Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting host path with command line arguement, with environment variable and with roman config #8

Open
wants to merge 1 commit into
base: milestone0.4
Choose a base branch
from
Open

Allow setting host path with command line arguement, with environment variable and with roman config #8

wants to merge 1 commit into from
+148 −18

Conversation

JohnDing1995
Copy link

@JohnDing1995 JohnDing1995 commented May 28, 2019 •
edited
Loading

Tell docker back-end the location of source file on host machine(if running roman on a container)
The priority order is

  1. Global configure
  2. Environment variable
  3. Command line parament

@JohnDing1995 JohnDing1995 changed the title Add -p parameter, Allow setting host path with command line arguement, with environment variable and with roman config Jun 3, 2019
raphendyr
raphendyr reviewed Jun 5, 2019
View reviewed changes
apluslms_roman/cli.py Outdated Show resolved Hide resolved
raphendyr
raphendyr reviewed Jun 5, 2019
View reviewed changes
apluslms_roman/builder.py Outdated Show resolved Hide resolved
raphendyr
raphendyr reviewed Jun 5, 2019
View reviewed changes
apluslms_roman/builder.py Outdated Show resolved Hide resolved
raphendyr
raphendyr reviewed Jun 5, 2019
View reviewed changes
apluslms_roman/builder.py Outdated Show resolved Hide resolved
raphendyr
raphendyr reviewed Jun 10, 2019
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
raphendyr
raphendyr reviewed Jun 10, 2019
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
raphendyr
raphendyr reviewed Jun 10, 2019
View reviewed changes
test/test_json_regex.py Outdated Show resolved Hide resolved
raphendyr
raphendyr reviewed Jun 10, 2019
View reviewed changes
apluslms_roman/cli.py Outdated Show resolved Hide resolved
@JohnDing1995 JohnDing1995 force-pushed the milestone0.3 branch 2 times, most recently from ccaa7c5 to fd2d132 Compare June 11, 2019 11:46
raphendyr
raphendyr reviewed Jun 11, 2019
View reviewed changes
tests/test_json_regex.py Outdated Show resolved Hide resolved
@JohnDing1995 JohnDing1995 force-pushed the milestone0.3 branch 3 times, most recently from 6502a84 to 8d2ea71 Compare July 8, 2019 12:00
@JohnDing1995 JohnDing1995 force-pushed the milestone0.3 branch 13 times, most recently from 1951da7 to 576042b Compare July 8, 2019 15:11
@JohnDing1995
Support setting the mapping for build source path between container a…
7ae4607 
…nd host mechine

* Set the path mapping with global config *.yml file
* If the mapping is not set on global config file, try to read the mapping from environment variable.
@raphendyr
Copy link
Contributor

raphendyr commented Aug 13, 2019 •
edited
Loading

After a long though, I have come to conclusion. I think we will move forward with creating a volume, then uploading the course material to the volume and running the builds. To speed up this in iterative builds, we can use librsync or similar to upload only changed files.

Thus, before closing this PR, we need to:

  • Split the docker backend features (better docker object creation)
  • Use the json_re etc. when reading environment variables for roman configuration (the generic case)

In addition, we will look into implementing the volume stuff. Until that, the current system works for local building (the currently supported usecase).

@raphendyr raphendyr mentioned this pull request Aug 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphendyr raphendyr raphendyr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnDing1995 @raphendyr