Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filters to Dolos integration in Radar #52

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

mikaelGusse
Copy link
Contributor

@mikaelGusse mikaelGusse commented Sep 18, 2024

Description

What?

Add filters to Dolos integration to allow the user to only send one submission per student or even just flagged submissions.
image

Why?

This should considerably speed up report generation and report readability.

How?

Changed Radar+Dolos UI with a select box which allows the user to select a filter mode. Added more functions to the Exercise model to allow for returning different sets of submissions.

Fixes #

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

[ADD A DESCRIPTION ABOUT WHAT YOU TESTED MANUALLY]

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

@mikaelGusse mikaelGusse marked this pull request as ready for review September 19, 2024 11:59
@mikaelGusse mikaelGusse requested review from murhum1 and removed request for murhum1 October 8, 2024 09:50
@mikaelGusse mikaelGusse merged commit 8f8c9ef into apluslms:master Oct 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants