Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The language the course is currently browsed in isn't displayed #849

Closed
etanttila opened this issue Aug 9, 2021 · 1 comment · Fixed by #1426
Closed

The language the course is currently browsed in isn't displayed #849

etanttila opened this issue Aug 9, 2021 · 1 comment · Fixed by #1426
Assignees
@ihalaij1
Labels
area: user interface User interface issues that are not specifically about navigation or user experience (UX) effort: hours Estimated to take less than one day, from the creation of a new branch to the merging experience: beginner required knowledge estimate priority: medium Valid issue, good to fix but cannot be scheduled yet requester: CS The issue is raised internally by a CS teacher requester: team The issue is raised by a person inside the A+ developer team type: feature New feature or change to a feature

Comments

@etanttila
Copy link
Contributor

The language the course is currently being displayed in is not displayed anywhere, neither on desktop or mobile.

image

image

If the idea in #428 of listing the language code next to the language icon is implemented, that might help. However, I think having a "Change language" dropdown displaying just one language is rather misleading. I'd prefer the dropdown to display all possible languages with the selected one highlighted, marked as active, checkmarked or something
@markkuriekkinen markkuriekkinen added area: user interface User interface issues that are not specifically about navigation or user experience (UX) effort: days Estimated to take less than one week, from the creation of a new branch to the merging experience: beginner required knowledge estimate priority: medium Valid issue, good to fix but cannot be scheduled yet requester: team The issue is raised by a person inside the A+ developer team type: feature New feature or change to a feature labels Sep 3, 2021
@markkuriekkinen markkuriekkinen added effort: hours Estimated to take less than one day, from the creation of a new branch to the merging requester: CS The issue is raised internally by a CS teacher requires: priority Currently using this label to flag issues that need EDIT decision ASAP (even if there was priority) and removed effort: days Estimated to take less than one week, from the creation of a new branch to the merging labels Nov 29, 2021
@markkuriekkinen
Copy link
Contributor

Teachers have requested this quite a lot.

@annirytkonen annirytkonen removed the requires: priority Currently using this label to flag issues that need EDIT decision ASAP (even if there was priority) label May 9, 2022
@ihalaij1 ihalaij1 self-assigned this Nov 25, 2024
@ihalaij1 ihalaij1 moved this to Todo in A+ sprints Nov 25, 2024
ihalaij1 added a commit to ihalaij1/a-plus that referenced this issue Dec 9, 2024
@ihalaij1
Display currently selected course language
162355a 
Fixes apluslms#849
ihalaij1 added a commit to ihalaij1/a-plus that referenced this issue Dec 9, 2024
@ihalaij1
Display currently selected course language
15dc425 
Fixes apluslms#849
@ihalaij1 ihalaij1 mentioned this issue Dec 9, 2024
Merged
@ihalaij1 ihalaij1 moved this from Todo to Under review in A+ sprints Dec 9, 2024
ihalaij1 added a commit to ihalaij1/a-plus that referenced this issue Dec 9, 2024
@ihalaij1
Display currently selected course language
aa70105 
Fixes apluslms#849
murhum1 pushed a commit that referenced this issue Jan 13, 2025
@ihalaij1 @murhum1
Display currently selected course language
b6afbe6 
Fixes #849
@github-project-automation github-project-automation bot moved this from Under review to Done in A+ sprints Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ihalaij1 ihalaij1

Labels
area: user interface User interface issues that are not specifically about navigation or user experience (UX) effort: hours Estimated to take less than one day, from the creation of a new branch to the merging experience: beginner required knowledge estimate priority: medium Valid issue, good to fix but cannot be scheduled yet requester: CS The issue is raised internally by a CS teacher requester: team The issue is raised by a person inside the A+ developer team type: feature New feature or change to a feature
Projects
A+ sprints
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Display currently selected course language ihalaij1/a-plus
4 participants
@markkuriekkinen @ihalaij1 @etanttila @annirytkonen