Add category configuring, and default accept unofficial to true for active elements #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Of note is whether the solution to the max submissions/accept unofficial submissions problem is satisfactory. Does changing the category of active elements exercises with max submissions cause issues to some courses? |
markkuriekkinen
suggested changes
Jun 13, 2023
There was a problem hiding this comment.
Great, this looks good! I have a couple of comments below.
Of note is whether the solution to the max submissions/accept unofficial submissions problem is satisfactory. Does changing the category of active elements exercises with max submissions cause issues to some courses?
I think it is good. I don't think changing the category hurts any current user.
Active elements with max submissions are put in a separate category "active elements with max submissions" that doesn't accept unofficial submisions by default. Closes apluslms#165
Closes apluslms#162. Category source priority: 1. RST options 2. yaml config 3. "active elements" or "active elements with max submissions" depending on whether max_submissions = 0 or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What?
Add easier category configuring, and accept unofficial submissions by default to active elements exercises without max submissions.
Why?
To close #165.
How?
Active elements with max submissions are put in a separate category "active elements with max submissions" that doesn't accept unofficial submisions by default.
Closes #162
Closes #164
Closes #165
Testing
What type of test did you run?
Tried changing the category options in conf.py, and checked that the changes happen in A+. Also checked that "active elements" category accepts unofficial submission by default and that it can be overridden in conf.py.