Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group setting for questionnaires and submits #70

Closed
markkuriekkinen opened this issue Mar 31, 2020 · 9 comments · Fixed by #154
Closed

Group setting for questionnaires and submits #70

markkuriekkinen opened this issue Mar 31, 2020 · 9 comments · Fixed by #154
Assignees
Labels
area: config Course configuration experience: good first issue Good for newcomers priority: high Important issue

Comments

@markkuriekkinen
Copy link
Contributor

The RST questionnaire directive should have options max-group-size and min-group-size so that the group size settings can be configured for each questionnaire separately instead of only using the course-wide default settings from conf.py.

In addition, the group size options shall be added to the submit directive too. Those exercises can use settings from the linked config.yaml file, but it is nice to have basic settings in the RST directive options too. The RST options are prioritized if the same settings are defined in two places.

Some advice:

@markkuriekkinen markkuriekkinen added area: config Course configuration experience: good first issue Good for newcomers priority: high Important issue labels Mar 31, 2020
@raphendyr
Copy link
Contributor

Two things. First. I think most of the directives should use inheritance to include common options, like group sizes. Second, MOOC-Jutut doesn't support groups, but other feedback backends of course.

@oseppala
Copy link
Contributor

Correct me if Im wrong, but isn't this just adding these to lines in the option spec:
'max_group_size': directives.nonnegative_int,
'min_group_size': directives.nonnegative_int,

I can set the value through a corresponding YAML. Only the option spec is missing.

@oseppala
Copy link
Contributor

(I managed to disable an exercise today by using the max_group_size variable in RST)

@markkuriekkinen
Copy link
Contributor Author

Yes, this would be easy to add to the a-plus-rst-tools code, but it hasn't been done yet.

@markkuriekkinen
Copy link
Contributor Author

max_group_size

RST directive options prefer the spelling max-group-size.

@oseppala
Copy link
Contributor

True, thats the variable name in python. Then its edits on lines 116 and 117 in the same style as 115.

@oseppala
Copy link
Contributor

That should be a 15 minutes task

@oseppala
Copy link
Contributor

And it's not just questionnaires!

@oseppala oseppala changed the title Group setting for questionnaires Group setting for questionnaires and submits Sep 26, 2022
@markkuriekkinen markkuriekkinen moved this from Todo to In Progress in A+ sprints Dec 2, 2022
EerikSaksi added a commit to EerikSaksi/a-plus-rst-tools that referenced this issue Dec 2, 2022
Define min-group-size and max-group-size directives in
ConfigurableExercise, and add data to Questionnaire and SubmitForm

Fixes apluslms#70
@markkuriekkinen markkuriekkinen moved this from In Progress to Under review in A+ sprints Dec 2, 2022
markkuriekkinen pushed a commit to EerikSaksi/a-plus-rst-tools that referenced this issue Dec 14, 2022
Define min-group-size and max-group-size options in
the exercise directives `submit` and `questionnaire`.

Fixes apluslms#70
markkuriekkinen pushed a commit that referenced this issue Dec 14, 2022
Define min-group-size and max-group-size options in
the exercise directives `submit` and `questionnaire`.

Fixes #70
Repository owner moved this from Under review to Done in A+ sprints Dec 14, 2022
@markkuriekkinen
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: config Course configuration experience: good first issue Good for newcomers priority: high Important issue
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants