-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate and add docs for Gaussian objects containing symbolic variables #43
Comments
Fe-r-oz
added a commit
to Fe-r-oz/Gabs.jl
that referenced
this issue
Feb 4, 2025
…ing symbolic variables
apkille
added a commit
that referenced
this issue
Feb 7, 2025
…c variables (#44) * resolve #43 Validate and add docs for Gaussian objects containing symbolic variables * fix extra space * Symbolic squeezed states * Symbolic coherent states * remove stupid mistake - add Symbolics to tests and docs, Latexify to docs * add Missings to typos * remove Latexify as dependency - just use it in docs via doc project toml * polish * shift documentation from manual to tutorial * fix small typo * Update docs/src/tutorials.md Co-authored-by: Andrew Kille <[email protected]> * Update docs/src/tutorials.md Co-authored-by: Andrew Kille <[email protected]> * Update docs/src/tutorials.md Co-authored-by: Andrew Kille <[email protected]> * add codereview suggestions: improve tutorial * add codereview suggestions: use rs and thetas for squeezedstates * add code review suggestion: alphas for coherent state * add code review suggestion: remove redundancy in EPR tests * symbolic tensor products :) * fix the doctest error that was causes by using Latexify in doctest * Symbolic thermal states and tests * undo a change to project toml * use float(eltype(P) so thermal states work with symbolic and ints etc * Update docs/src/tutorials.md Co-authored-by: Andrew Kille <[email protected]> * Update docs/src/tutorials.md Co-authored-by: Andrew Kille <[email protected]> * Update docs/make.jl Co-authored-by: Andrew Kille <[email protected]> * Create .gitignore Add manifest in .gitignore * rm the first test set * add some tests from removed testset 1 to testset2 * don't show output of newst.covar in doctest, we are already doing it afterwards * polish testset 1 * Delete Manifest.toml --------- Co-authored-by: Andrew Kille <[email protected]>
Following the completing of #44, the TODOs are:
I have submitted a basic attempt for TODO 1 at #46 :) Thank you so much for support and help in reviewing the PRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See qojulia/QuantumOpticsBase.jl#184 for a discussion. Symbolic variables from Symbolics.jl actually integrate quite nicely with Gabs:
So it would be great to make these features accessible in the tutorials section of the documentation, and add tests for them so they don't break in the future.
The text was updated successfully, but these errors were encountered: