Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more -i is not portable #71

Closed
paravoid opened this issue Jan 1, 2021 · 3 comments
Closed

more -i is not portable #71

paravoid opened this issue Jan 1, 2021 · 3 comments
Assignees
@apjanke
Labels
bug Something isn't working
Milestone
0.10.1

Comments

@paravoid
Copy link

paravoid commented Jan 1, 2021

ronn has:

pager = ENV['MANPAGER'] || ENV['PAGER'] || 'more -is'

However, more -i does not work on my Debian buster system:

$ echo | more -is
more: unknown option -is
Try 'more --help' for more information.

And therefore, ronn -m fails out of the box.
@apjanke
Copy link
Owner

apjanke commented Jan 6, 2021

This was introduced in f528c25. Looks like I did not do my portability research: on macOS, more is an alias for less. -i is a less option, not a more option. I'll remove it.

Thanks for all the bug reports, by the way!

@apjanke apjanke self-assigned this Jan 6, 2021
@apjanke apjanke added the bug Something isn't working label Jan 6, 2021
@apjanke apjanke added this to the 0.10.0 milestone Jan 6, 2021
@apjanke apjanke closed this as completed in 33b8f54 Jan 6, 2021
@apjanke
Copy link
Owner

apjanke commented Jan 6, 2021 •
edited
Loading

Fixed in 33b8f54. This will go out in the 0.10 release.

@zgyarmati
Copy link

Just for the time travelers from the future who will also hit this before 0.10 is released, the workaround is to set the PAGER or the MANPAGER environment variable to more (or less) before calling ronn as in:

> export PAGER=more
> ronn -m ....

@ghost ghost mentioned this issue Sep 29, 2021
Merged
deivid-rodriguez added a commit to deivid-rodriguez/ronn-ng that referenced this issue Dec 28, 2022
@deivid-rodriguez
Revert "Merge pull request apjanke#71 from freeformsystems/master"
bfb1f5d 
This reverts commit e7df1f0, reversing
changes made to c3fd67e.

Commit was introduce as a aesthetic change when using `-Kutf8 -Tutf8`.

Quoting from the issue that led to the PR:

> This may seem a little strange, it's more aesthetic then anything
> else. When troff is run with -Kutf8 -Tutf8 to ensure that utf8
> characters appear correctly then the bullets generated by \(bu appear as
> small squares (I'm using 13pt Pragmata Pro).

However, in `bundler` we're not using `-Tutf8`, but `-Tascii`, and this
results in weird characters for list items as reported [here](cli-kit/cli-command#78).

Since this change never made it into any `ronn` release, I think
reverting it could encourage adoption of `ronn-ng` as a drop-in
replacement of `ronn`. At least for us :)
@apjanke apjanke modified the milestones: 0.10.0, 0.10.1 Dec 31, 2022
@apjanke apjanke added this to ronn-ng Jan 4, 2024
@apjanke apjanke moved this to Closed in ronn-ng Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apjanke apjanke

Labels
bug Something isn't working
Projects
ronn-ng
Archived in project
Milestone
0.10.1
Development

No branches or pull requests
3 participants
@paravoid @zgyarmati @apjanke