Support PHP 8 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bakerkretzmar Thank you for your hard work, especially for adding the GitHub workflow for testing. |
|
This PR is part of the latest version: https://github.com/apimatic/jsonmapper/releases/tag/v2.0.2 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for PHP 8 by:
->getClass()method on aReflectionParameterif running PHP 8.0 or higher.instead of+to concatenate stringsphpunit/phpunit:^8.0.0As far as I know Travis CI does not support PHP 8, so I also moved your CI from Travis to GitHub Actions. Your tests will run automatically on all pull requests and all pushes to the
masterbranch, and it's free for public repos. The setup and tests are unchanged and they all pass, you can view the output on my fork: https://github.com/bakerkretzmar/jsonmapper/pull/1/checks.Closes #6.