Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(additional-properties): adds support for typed additional properties #54

Merged

Conversation

asadali214
Copy link
Collaborator

What

This PR adds the capability to set up additional properties of a particular type, while the jsonmapper ignore invalid types silently

Why

To support typed/strict additional properties

Closes #53

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

N/A

Breaking change

N/A

Testing

I have added unit tests to my code

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

@asadali214 asadali214 linked an issue Nov 26, 2024 that may be closed by this pull request
@asadali214 asadali214 self-assigned this Nov 26, 2024
Copy link

@haseeb-mhr haseeb-mhr self-requested a review November 28, 2024 07:45
Copy link

@haseeb-mhr haseeb-mhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asadali214 asadali214 merged commit 540f642 into master Nov 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for setting up typed additional properties in models
2 participants