Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(setuptools): bump version to 68.0.0 for setuptools #50

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

sufyankhanrao
Copy link
Collaborator

@sufyankhanrao sufyankhanrao commented Jan 29, 2024

What

This PR bumps the version of the setuptools dependency to the 68.0.0.

closes #49

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

If a new dependency is being added, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Policy-of-adding-new-dependencies-in-the-core-libraries

Breaking change

If the PR is introducing a breaking change, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Guidelines-for-maintaining-core-libraries

Testing

List the steps that were taken to test the changes

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added new unit tests

@sufyankhanrao sufyankhanrao added the dep-version-upgrade This is used whenever any dependency version gets upgraded in the library. label Jan 29, 2024
@sufyankhanrao sufyankhanrao self-assigned this Jan 29, 2024
This commit bumps the version of the setuptools to 68.0.0.

closes #49
@sufyankhanrao sufyankhanrao force-pushed the 49-bump-setuptools-dependency-version branch from f5c6b2a to 870bc1a Compare January 29, 2024 10:21
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sufyankhanrao sufyankhanrao changed the title build(setuptools): bump version to the latest for setuptools build(setuptools): bump version to 68.0.0 for setuptools Jan 29, 2024
setup.py Show resolved Hide resolved
Copy link
Contributor

@MaryamAdnan3 MaryamAdnan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sufyankhanrao sufyankhanrao merged commit 7f5b3e3 into main Jan 29, 2024
7 checks passed
@sufyankhanrao sufyankhanrao deleted the 49-bump-setuptools-dependency-version branch January 29, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dep-version-upgrade This is used whenever any dependency version gets upgraded in the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setuptools Pinning Causes Pip Issues
2 participants