Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the HttpCallback method virtual to allow overriding the behavior #78

Closed
sufyankhanrao opened this issue Aug 30, 2024 · 0 comments · Fixed by #79
Closed

Make the HttpCallback method virtual to allow overriding the behavior #78

sufyankhanrao opened this issue Aug 30, 2024 · 0 comments · Fixed by #79
Assignees
@sufyankhanrao
Labels
refactoring

Comments

@sufyankhanrao
Copy link
Contributor

The task is to make the HttpCallback class configurable by making the OnBeforeHttpRequestEventHandler and OnAfterHttpResponseEventHandler method virtual so that the SDK could override them and allow to call the callbacks overrided by users.
@sufyankhanrao sufyankhanrao added the enhancement New feature or request label Aug 30, 2024
@sufyankhanrao sufyankhanrao self-assigned this Aug 30, 2024
@sufyankhanrao sufyankhanrao added refactoring and removed enhancement New feature or request labels Aug 30, 2024
sufyankhanrao added a commit that referenced this issue Aug 30, 2024
@sufyankhanrao
refactor(http-callback): make Http Callback class override-able
10a6120 
This commit makes `OnBeforeHttpRequestEventHandler` and `OnAfterHttpResponseEventHandler` methods virtual. This allows SDKs to override these methods and invoke user-overridden callbacks methods provided in the SDK class.

Closes #78
@sufyankhanrao sufyankhanrao mentioned this issue Aug 30, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sufyankhanrao sufyankhanrao

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(http-callback): make Http Callback class override-able apimatic/core-lib-csharp
1 participant
@sufyankhanrao