Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(response-validation): request builder schema validation and numeric value handling issues #183

Merged
merged 3 commits into from
Jul 18, 2024
Merged

fix(response-validation): request builder schema validation and numeric value handling issues #183

merged 3 commits into from
Jul 18, 2024

Conversation

asadali214
Copy link
Collaborator

This PR adds the following changes:

  • Sending a primitive value as body in requests
  • Receiving a string response without validation as JSON
  • Empty response body handling
  • Moved HttpClientInterface from requestBuilder to packages/core-interfaces/src/httpClient.ts. So it can used further in other packages in the future

@asadali214 asadali214 requested a review from MaryamAdnan3 July 15, 2024 06:53
@asadali214 asadali214 self-assigned this Jul 15, 2024
MaryamAdnan3
MaryamAdnan3 previously approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@MaryamAdnan3 MaryamAdnan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the code climate issue if possible

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@asadali214 asadali214 requested a review from MaryamAdnan3 July 18, 2024 07:05
MaryamAdnan3
MaryamAdnan3 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@MaryamAdnan3 MaryamAdnan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asadali214 asadali214 merged commit ad18ad0 into master Jul 18, 2024
10 checks passed
@asadali214 asadali214 deleted the fix-request-builder-http-client branch July 18, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaryamAdnan3 MaryamAdnan3 MaryamAdnan3 approved these changes

Assignees

@asadali214 asadali214

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asadali214 @MaryamAdnan3