Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds support to deploy sf from gh #294 #298

Merged
merged 2 commits into from
Sep 19, 2023
Merged

feat: adds support to deploy sf from gh #294 #298

merged 2 commits into from
Sep 19, 2023

Conversation

srinandan
Copy link
Collaborator

No description provided.

@srinandan srinandan linked an issue Sep 19, 2023 that may be closed by this pull request
Add support for github when creating shared flows #294
Closed
@srinandan srinandan added the enhancement New feature or request label Sep 19, 2023
@ssvaidyanathan ssvaidyanathan requested review from kurtkanaskie and removed request for kurtkanaskie and ssvaidyanathan September 19, 2023 17:27
kurtkanaskie
kurtkanaskie requested changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@kurtkanaskie kurtkanaskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs page for apigee sharedflows create needs sub-commands for bundle and github.

docs/apigeecli_sharedflows_create.md

@kurtkanaskie kurtkanaskie self-requested a review September 19, 2023 17:59
kurtkanaskie
kurtkanaskie approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@kurtkanaskie kurtkanaskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given doc pages are auto-generated - LGTM!

@ssvaidyanathan ssvaidyanathan merged commit 5137053 into main Sep 19, 2023
5 checks passed
@srinandan srinandan deleted the issue294 branch September 20, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtkanaskie kurtkanaskie kurtkanaskie approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for github when creating shared flows
3 participants
@srinandan @kurtkanaskie @ssvaidyanathan