Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added changes for AppGroup Apps pagination #926

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

shishir-intelli
Copy link
Collaborator

Implemented pagination for Apigee-X AppGroup Apps.
Fix issue showing 1000+ apps for Apigee X.
Closes apigee/apigee-client-php#305

@shishir-intelli shishir-intelli added the enhancement New feature or request label Sep 5, 2023
@shishir-intelli shishir-intelli added this to the 2.1.2 milestone Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #926 (30c49b2) into 2.x (aa3d60d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x     #926   +/-   ##
=========================================
  Coverage     43.92%   43.92%           
  Complexity     3026     3026           
=========================================
  Files           344      344           
  Lines         11135    11135           
=========================================
  Hits           4891     4891           
  Misses         6244     6244           
Files Changed Coverage Δ
src/Entity/Controller/AppByOwnerController.php 82.75% <ø> (ø)
..._teams/src/Entity/Controller/TeamAppController.php 55.55% <100.00%> (ø)

@shishir-intelli shishir-intelli marked this pull request as ready for review September 11, 2023 11:18
Copy link
Collaborator

@divya-intelli divya-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shishir-intelli shishir-intelli merged commit 7991265 into apigee:2.x Sep 15, 2023
@shishir-intelli shishir-intelli deleted the appgroup_apps_pagination branch November 30, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

3 participants