Extract user deletion into a new service #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just spotted cc @FCsongradi |
Introduce a programming API for downstream developers that allows customizing what should happen when a user is deleted in Drupal. Co-authored-by: Dezső BICZÓ <[email protected]>
mxr576
commented
Aug 30, 2023
| */ | ||
| interface UserRemovalHandlerInterface { | ||
| interface PostUserDeleteActionPerformerInterface { |
There was a problem hiding this comment.
Is is better? I mean, naming is hard... but I think it is better to be explicit and descriptive in names (in domain driven style) when designing public APIs. If we like this I can squash this change to other commits.
mxr576
commented
Aug 30, 2023
| * {@inheritdoc} | ||
| */ | ||
| public function __invoke(UserInterface $account): void { | ||
| ($this->decorated)($account); |
There was a problem hiding this comment.
Double checked and this was the original order as well, the hook in apigee_edge was called sooner than in this module - which makes total sense.
shishir-intelli
approved these changes
Aug 31, 2023
mxr576
added a commit
to FCsongradi/apigee-edge-drupal
that referenced
this pull request
Sep 1, 2023
* Extract user deletion into a new service Introduce a programming API for downstream developers that allows customizing what should happen when a user is deleted in Drupal. Co-authored-by: Dezső BICZÓ <[email protected]> * Leverage the new user removal handler API for cascade deleting team roles * Better naming for the new API and implementations --------- Co-authored-by: ferenc.csongradi <[email protected]>
shishir-intelli
pushed a commit
that referenced
this pull request
Sep 4, 2023
* Extract user deletion into a new service Introduce a programming API for downstream developers that allows customizing what should happen when a user is deleted in Drupal. * Leverage the new user removal handler API for cascade deleting team roles * Better naming for the new API and implementations --------- Co-authored-by: Dezső BICZÓ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a programming API for downstream developers that allows customizing what should happen when a user is deleted in Drupal.
Co-authored-by: @FCsongradi
Closes #915