Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Add AppGroup team and update App key credentials with ApiProduct #824

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

shishir-intelli
Copy link
Collaborator

Implemented support for adding a Team/AppGroup (Add Team) and support for updating a team app with ApiProduct while adding a team app.

@shishir-intelli shishir-intelli added the enhancement New feature or request label Mar 23, 2023
@shishir-intelli shishir-intelli self-assigned this Mar 23, 2023
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #824 (8f19a42) into appgroup (79881f9) will decrease coverage by 0.03%.
The diff coverage is 54.54%.

Impacted file tree graph

@@              Coverage Diff               @@
##             appgroup     #824      +/-   ##
==============================================
- Coverage       44.67%   44.65%   -0.03%     
- Complexity       2936     2939       +3     
==============================================
  Files             338      338              
  Lines           10813    10821       +8     
==============================================
+ Hits             4831     4832       +1     
- Misses           5982     5989       +7     
Impacted Files Coverage Δ
...les/apigee_edge_teams/src/Entity/Form/TeamForm.php 0.00% <0.00%> (ø)
src/Entity/App.php 88.50% <0.00%> (-1.03%) ⬇️
src/Entity/Controller/OrganizationController.php 41.66% <ø> (ø)
src/Entity/Form/AppCreateForm.php 0.00% <0.00%> (ø)
src/Entity/Form/AppEditForm.php 0.00% <0.00%> (ø)
src/Entity/Form/AppForm.php 0.00% <0.00%> (ø)
src/Plugin/KeyInput/ApigeeAuthKeyInput.php 0.00% <0.00%> (ø)
src/Plugin/QueueWorker/JobQueueWorker.php 100.00% <ø> (ø)
...teams/src/Entity/Storage/TeamMemberRoleStorage.php 57.57% <75.00%> (ø)
...apigee_edge_teams/src/CompanyMembersController.php 90.47% <100.00%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

@shishir-intelli shishir-intelli merged commit 8d77126 into apigee:appgroup Mar 28, 2023
shishir-intelli added a commit that referenced this pull request Jun 23, 2023
* Checking if the organisation is ApigeeX for AppGroup (#803)

* Fix organisation exception (#806)

* Changes for Appgroup listing/view/edit/delete page (#805)

* Changes for Appgroup listing/view/edit/delete page

* Update composer.json

* Update composer.json

* AppGroup-App implementation for list, view, edit, delete apps (#813)

* Merge 2.x into appgroup (#829)

* Warrant that queues executed by cron (#808)

* Sort API Product listings on App (#812)

* Update endpoints to use constants from ClientInterface (#810)

* Sort API products on app forms by API product display name (#815)

* Sort API Products (#818)

* Sort API Products
TypeError: array_map(): Argument #2 ($array) must be of type array

* Removed test case

* App creation fails without API Products (#809)

* App creation fails without API Products caused by features.keymanagement.disable.unbounded.permissions flag
* Update minimum version of apigee-client-php

* Make sure that cron runner starts executing the job (#814)

* Checking if the organisation is ApigeeX for AppGroup (#803)

* Fix organisation exception (#806)

* Changes for Appgroup listing/view/edit/delete page (#805)

* Changes for Appgroup listing/view/edit/delete page

* Update composer.json

* Update composer.json

* AppGroup-App implementation for list, view, edit, delete apps (#813)

---------

Co-authored-by: Dezső BICZÓ <[email protected]>
Co-authored-by: Shishir <[email protected]>
Co-authored-by: phdhiren <[email protected]>
Co-authored-by: Divyajose <[email protected]>

* Support for Add AppGroup/team and update team App credentials with ApiProduct (#824)

* Support for AppGroup membership (#825)

* The Apigee Edge and X Teams module requirements (#826)

* Checking ApigeeX org from OrganizationController and removed from SDKController (#832)

* If team not available on Apigee avoid null value exception (#833)

* Added admin config setting for Team prefix and channelID (#839)

* Implemented AppGroup membership feature for ApigeeX (#843)

* Merge 2.x into appgroup branch (#859)

* Warrant that queues executed by cron (#808)

* Sort API Product listings on App (#812)

* Update endpoints to use constants from ClientInterface (#810)

* Sort API products on app forms by API product display name (#815)

* Sort API Products (#818)

* Sort API Products
TypeError: array_map(): Argument #2 ($array) must be of type array

* Removed test case

* App creation fails without API Products (#809)

* App creation fails without API Products caused by features.keymanagement.disable.unbounded.permissions flag
* Update minimum version of apigee-client-php

* Make sure that cron runner starts executing the job (#814)

* Update the storage defination of App entity (#831)

* Fix issue which removes users from all team (#840)

* Drop PHP 7 support again (#816)

* Revert "Support for PHP 7.4 (#800)"

This reverts commit b71f8a9.

* Clearly specify the currently supported PHP versions

* Update outdated info.yml

* Added accessCheck on entity queries (#842)

* added accessCheck on entity queries

Co-authored-by: Vladimir Roudakov <[email protected]>

* added comment

---------

Co-authored-by: Vladimir Roudakov <[email protected]>

* Fix for jQuery.once() is deprecated in Drupal 9.3 (#851)

Co-authored-by: Vladimir Roudakov <[email protected]>

* fix for phpcs failing in github action (#858)

* PHPCS FIX

---------
Co-authored-by: Shishir <[email protected]>
Co-authored-by: Dezső BICZÓ <[email protected]>
Co-authored-by: Gitesh Koli <[email protected]>
Co-authored-by: Divyajose <[email protected]>
Co-authored-by: Vladimir Roudakov <[email protected]>

* Implemented AppGroup Team Membership Sync (#853)

* Get AppGroup team members from DB (#864)

* Get AppGroup team members from DB and fix recurring teams api call

* Declaring abstract method

* Fix action module getTeam method argument

* Fix for team sync issue when DB is empty

* Added team member sync note for ApigeeX (#867)

---------

Co-authored-by: Shishir <[email protected]>
Co-authored-by: Divyajose <[email protected]>
Co-authored-by: Gitesh Koli <[email protected]>
Co-authored-by: Dezső BICZÓ <[email protected]>
Co-authored-by: Vladimir Roudakov <[email protected]>
@shishir-intelli shishir-intelli deleted the appgroup-addteam branch July 6, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants