Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set missing operation on AuthenticationForm #792

Merged
merged 3 commits into from
Feb 2, 2023

Conversation

FCsongradi
Copy link
Contributor

@FCsongradi FCsongradi commented Feb 1, 2023

Closes #793

@google-cla
Copy link

google-cla bot commented Feb 1, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@mxr576 mxr576 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #792 (dfe5741) into 2.x (d235c18) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x     #792      +/-   ##
============================================
- Coverage     44.86%   44.83%   -0.04%     
- Complexity     2899     2900       +1     
============================================
  Files           337      337              
  Lines         10718    10727       +9     
============================================
  Hits           4809     4809              
- Misses         5909     5918       +9     
Impacted Files Coverage Δ
src/Form/AppApiKeyAddFormBase.php 0.00% <0.00%> (ø)
src/Form/AuthenticationForm.php 0.00% <ø> (ø)

Copy link
Collaborator

@shishir-intelli shishir-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @FCsongradi and @mxr576 !
LGTM too

@shishir-intelli shishir-intelli added this to the 2.0.9 milestone Feb 2, 2023
@shishir-intelli shishir-intelli merged commit 2f1f6d9 into apigee:2.x Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing operation on custom entity form.
3 participants