Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using "min" option without setting the "allowEmptyString" is deprecated #765

Merged
merged 3 commits into from
Dec 19, 2022

Conversation

divya-intelli
Copy link
Collaborator

Fixes #759
Using the "Symfony\Component\Validator\Constraints\Length" constraint with the "min" option without setting the "allowEmptyString" one is deprecated and defaults to true.

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #765 (46fec30) into 2.x (5857361) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x     #765   +/-   ##
=========================================
  Coverage     44.91%   44.91%           
  Complexity     2895     2895           
=========================================
  Files           337      337           
  Lines         10697    10697           
=========================================
  Hits           4805     4805           
  Misses         5892     5892           

Copy link
Collaborator

@shishir-intelli shishir-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@divya-intelli divya-intelli merged commit e0de946 into apigee:2.x Dec 19, 2022
@shishir-intelli shishir-intelli added this to the 2.0.7 milestone Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants