Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team member sync #745

Merged
merged 5 commits into from
Nov 16, 2022
Merged

Team member sync #745

merged 5 commits into from
Nov 16, 2022

Conversation

divya-intelli
Copy link
Collaborator

@divya-intelli divya-intelli commented Oct 18, 2022

Fixes #746

@divya-intelli divya-intelli marked this pull request as ready for review October 19, 2022 07:02
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #745 (38e1acd) into 2.x (a902f6c) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x     #745   +/-   ##
=========================================
  Coverage     48.82%   48.82%           
  Complexity     2844     2844           
=========================================
  Files           329      329           
  Lines          8732     8732           
=========================================
  Hits           4263     4263           
  Misses         4469     4469           
Impacted Files Coverage Δ
...apigee_edge_teams/src/Entity/TeamAccessHandler.php 0.00% <0.00%> (ø)
...es/apigee_edge_teams/src/TeamPermissionHandler.php 90.00% <100.00%> (ø)

Copy link
Collaborator

@shishir-intelli shishir-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@divya-intelli ,
Team sync functionality is working fine and updating data in the database,
However on the Teams page I couldn't see more than 100 teams. It is still displaying only 100 teams even after changing the permission View extensive teams list

@divya-intelli
Copy link
Collaborator Author

@shishir-intelli , the issue is fixed now, there was a bug in the condition which was restricted in displaying more than 100 teams. Please check.

Copy link
Collaborator

@shishir-intelli shishir-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@divya-intelli
Yes, It is working now,
But it displays more than 100 teams only when the View extensive teams list permission is enabled ( #744 changes ) and Cache has not expired.

IMO, we should add some help text about enabling View extensive teams list permission and setting the Cache time limit here for more clarity. (/admin/config/apigee-edge/app-settings/team-settings/sync)
image

@divya-intelli divya-intelli merged commit c9028a4 into apigee:2.x Nov 16, 2022
@divya-intelli divya-intelli added this to the 2.0.6 milestone Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create team member sync(manual and automated)
3 participants