-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Team member sync #745
Team member sync #745
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #745 +/- ##
=========================================
Coverage 48.82% 48.82%
Complexity 2844 2844
=========================================
Files 329 329
Lines 8732 8732
=========================================
Hits 4263 4263
Misses 4469 4469
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@divya-intelli ,
Team sync
functionality is working fine and updating data in the database,
However on the Teams page I couldn't see more than 100 teams. It is still displaying only 100 teams even after changing the permission View extensive teams list
@shishir-intelli , the issue is fixed now, there was a bug in the condition which was restricted in displaying more than 100 teams. Please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@divya-intelli
Yes, It is working now,
But it displays more than 100 teams only when the View extensive teams list
permission is enabled ( #744 changes ) and Cache has not expired.
IMO, we should add some help text about enabling View extensive teams list
permission and setting the Cache
time limit here for more clarity. (/admin/config/apigee-edge/app-settings/team-settings/sync
)
Fixes #746