Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for deprecation notice:$modules property must be declared protected #722

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Fix for deprecation notice:$modules property must be declared protected #722

merged 1 commit into from
Jun 22, 2022

Conversation

divya-intelli
Copy link
Collaborator

Closes #719

@divya-intelli divya-intelli added this to the 2.0.5 milestone Jun 20, 2022
shishir-intelli
shishir-intelli approved these changes Jun 22, 2022
View reviewed changes
Copy link
Collaborator

@shishir-intelli shishir-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@divya-intelli divya-intelli merged commit 463c333 into apigee:2.x Jun 22, 2022
@divya-intelli divya-intelli deleted the protected-module branch June 22, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shishir-intelli shishir-intelli shishir-intelli approved these changes

@raakesh-blokhra raakesh-blokhra Awaiting requested review from raakesh-blokhra

@phdhiren phdhiren Awaiting requested review from phdhiren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.5
Development

Successfully merging this pull request may close these issues.

$modules property must be declared protected
2 participants
@divya-intelli @shishir-intelli