Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for error in action debug where incorrect class is passed #688

Merged
merged 2 commits into from
Apr 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions .circleci/RoboFile.php
Original file line number Diff line number Diff line change
Expand Up @@ -523,20 +523,4 @@ public function configureModuleDependencies()
file_put_contents('composer.json', json_encode($config, JSON_PRETTY_PRINT));
}

/**
* Perform extra tasks per Drupal core version.
*
* @param int $drupalCoreVersion
* The major version of Drupal required.
*/
public function doExtra($drupalCoreVersion) {
if ($drupalCoreVersion > 8) {

// Delete D8 only modules.
$this->taskFilesystemStack()
->taskDeleteDir('modules/apigee_edge/modules/apigee_edge_actions')
->run();
}
}

}
1 change: 0 additions & 1 deletion .circleci/test-functional-js.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,5 @@ fi
apache2-foreground&

robo override:phpunit-config $1
robo do:extra $2

sudo -E -u www-data vendor/bin/phpunit -c core --group $1 --testsuite functional-javascript --debug --verbose --log-junit /tmp/artifacts/phpunit/phpunit.xml
1 change: 0 additions & 1 deletion .circleci/test-functional.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,5 @@ fi
apache2-foreground&

robo override:phpunit-config $1
robo do:extra $2

sudo -E -u www-data vendor/bin/phpunit -c core --group $1 --testsuite functional --debug --verbose --log-junit /tmp/artifacts/phpunit/phpunit.xml
1 change: 0 additions & 1 deletion .circleci/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ fi
apache2-foreground&

robo override:phpunit-config $1
robo do:extra $2
composer show

sudo -E -u www-data vendor/bin/phpunit -c core --group $1 --testsuite unit,kernel --debug --verbose --log-junit /tmp/artifacts/phpunit/phpunit.xml
1 change: 0 additions & 1 deletion .circleci/update-dependencies.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ robo add:dependencies-from modules/$1/composer.json
robo drupal:version $2
robo configure:module-dependencies
robo update:dependencies
robo do:extra $2

# Touch a flag so we know dependencies have been set. Otherwise, there is no
# easy way to know this step needs to be done when running circleci locally since
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
namespace Drupal\apigee_edge_actions_debug\EventSubscriber;

use Drupal\apigee_edge_actions\Event\ApigeeEdgeActionsEventInterface;
use Drupal\apigee_edge_actions\Event\EdgeEntityEventEdge;
use Drupal\Core\Logger\LoggerChannelInterface;
use Symfony\Contracts\EventDispatcher\Event;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;

/**
Expand Down Expand Up @@ -50,12 +50,12 @@ public function __construct(LoggerChannelInterface $logger) {
/**
* Responds to rules events.
*
* @param \Symfony\Contracts\EventDispatcher\Event $event
* @param \Drupal\apigee_edge_actions\Event\EdgeEntityEventEdge $event
* The event object.
* @param string $event_name
* The event name.
*/
public function onRulesEvent(Event $event, $event_name) {
public function onRulesEvent(EdgeEntityEventEdge $event, $event_name) {
// Log the dispatched event.
if ($event instanceof ApigeeEdgeActionsEventInterface) {
$this->logger->notice("Event $event_name was dispatched.");
Expand Down