Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some references to Drupal 8 #633

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Fixes some references to Drupal 8 #633

merged 2 commits into from
Dec 2, 2021

Conversation

earth2marsh
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes Indicates CLA has been signed label Oct 19, 2021
* The Apigee Edge module requires **Drupal 8.7.x** or higher and PHP 7.1 or higher.
* Drupal 8's minimum requirement is phpdocumentor/reflection-docblock:2.0.4 but at least 3.0 is required by this module. If you get the error "Your requirements could not be resolved to an installable set of packages" it may be because you are running reflection-docblock version 2. You can update `phpdocumentor/reflection-docblock` with the following command: `composer update phpdocumentor/reflection-docblock --with-dependencies`.
* The Apigee Edge module requires **Drupal 8.7.x** or higher and PHP 7.1 or higher, though Drupal 9.x is recommended due to [Drupal 8's EOL timeline](https://www.drupal.org/psa-2021-2021-06-29).
* Drupal's minimum requirement is phpdocumentor/reflection-docblock:2.0.4 but at least 3.0 is required by this module. If you get the error "Your requirements could not be resolved to an installable set of packages" it may be because you are running reflection-docblock version 2. You can update `phpdocumentor/reflection-docblock` with the following command: `composer update phpdocumentor/reflection-docblock --with-dependencies`.
* **Check [composer.json](https://github.com/apigee/apigee-edge-drupal/blob/8.x-1.x/composer.json) for any required patches.** Patches prefixed with "(For testing)" are only required for running tests. Those are not necessary for using this module. Patches can be applied with the [cweagans/composer-patches](https://packagist.org/packages/cweagans/composer-patches) plugin automatically or manually. See [Applying Patches](#applying-patches) section below.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the reference to to the composer.json to https://github.com/apigee/apigee-edge-drupal/blob/2.x/composer.json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, since the PHP API client dropped PHP 7.1/7.2 support therefore this module also has a minimum PHP 7.3 requirement ;)
https://github.com/apigee/apigee-client-php/releases/tag/2.0.11

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And possibly it is a good idea to define and announce and Drupal < 9 end of support schedule for this module (family), unless we have the capacity to support an unsupported Drupal version and everything that comes with the latest and greatest.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go ahead and make any additional improvements. I'm not sure how to take action on the suggestions, so perhaps merge this PR and begin another?

Copy link
Contributor

@raakesh-blokhra raakesh-blokhra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phdhiren phdhiren merged commit 18ebaa0 into 2.x Dec 2, 2021
@shishir-intelli shishir-intelli added this to the 2.0.1 milestone Dec 6, 2021
@giteshk giteshk deleted the earth2marsh-patch-1 branch June 15, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates CLA has been signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants