Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#508] Disable team actions if team is inactive #518

Merged
merged 4 commits into from
Nov 18, 2020
Merged

Conversation

shadcn
Copy link
Contributor

@shadcn shadcn commented Nov 10, 2020

Fixes #508

Since Drupal does not render links with \Drupal\Core\Access\AccessResultForbidden, we can't alter access here.

This PR implements an event_subscriber to alter the response when a team is inactive. An error message is displayed.

As for the UI part, we are replacing local actions and tasks with url <none> and showing a disabled state using CSS.

@google-cla google-cla bot added the cla: yes Indicates CLA has been signed label Nov 10, 2020
Copy link
Contributor

@arlina-espinoza arlina-espinoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I'll just check with the Apigee team before approving. I also added a comment requiring a small change.

Copy link
Contributor

@arlina-espinoza arlina-espinoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @arshad !

@shadcn shadcn marked this pull request as ready for review November 18, 2020 19:32
@shadcn shadcn merged commit 932364e into 8.x-1.x Nov 18, 2020
@arlina-espinoza arlina-espinoza deleted the 508-inactive-company branch November 18, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates CLA has been signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

able to modify app inside inactive company
2 participants