Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#478 Enable CI testing for D9 and fix deprecations #490

Merged
merged 7 commits into from
Sep 18, 2020

Conversation

arlina-espinoza
Copy link
Contributor

@arlina-espinoza arlina-espinoza commented Sep 15, 2020

Closes #478. This PR:

  • Enables the testing matrix against both D8 and D9.
  • Fixes some tests and deprecations, so the apigee_edge module and submodules can run in both D8 and D9 (with the exception of apigee_edge_actions, which is only for D8 because the rules module still doesn't have a D9 release).

Example of the test matrix in CircleCI:
image

@googlebot googlebot added the cla: yes Indicates CLA has been signed label Sep 15, 2020
Copy link
Contributor

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is a big win! Thanks @arlina-espinoza

@arlina-espinoza arlina-espinoza modified the milestone: 8.x-1.16 Sep 18, 2020
@arlina-espinoza arlina-espinoza merged commit b0b61db into apigee:8.x-1.x Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates CLA has been signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable CI testing matrix against both D8 and D9
3 participants