Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label entity_key for the team entity type #445

Merged
merged 2 commits into from
Aug 31, 2020
Merged

Add label entity_key for the team entity type #445

merged 2 commits into from
Aug 31, 2020

Conversation

boobaa
Copy link
Contributor

@boobaa boobaa commented Jul 15, 2020

fixes #444

@googlebot googlebot added the cla: yes Indicates CLA has been signed label Jul 15, 2020
@arunz6161 arunz6161 added this to the 8.x-1.13 milestone Jul 21, 2020
@@ -65,6 +65,7 @@
* },
* entity_keys = {
* "id" = "name",
* "label" = "displayName",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about other entity types? Is this information also missing from those?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arlina-espinoza the PR has been merged, does it mean that other entity types do not need this change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, if entity keys are changing, should not we add an update hook that updates the active entity definition on existing sites? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arunz6161 arunz6161 modified the milestones: 8.x-1.13, 8.x-1.14 Aug 5, 2020
@arlina-espinoza arlina-espinoza removed this from the 8.x-1.14 milestone Aug 5, 2020
Copy link
Contributor

@arlina-espinoza arlina-espinoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Indicates CLA has not been signed and removed cla: yes Indicates CLA has been signed labels Aug 18, 2020
@arlina-espinoza
Copy link
Contributor

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Indicates CLA has been signed and removed cla: no Indicates CLA has not been signed labels Aug 18, 2020
@arlina-espinoza arlina-espinoza merged commit affee4b into apigee:8.x-1.x Aug 31, 2020
@boobaa boobaa deleted the issue/444 branch March 11, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates CLA has been signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible to create a Node entity_referencing a Team in Behat
5 participants