[#396] Add a target bundle to first and last name user fields. #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least one module seems to think that user fields that should be exposed for other configuration should have a target bundle set, as a way to distinguish the fields from other internal fields (such as uuid, roles, etc). This is at least the case with the_CAS Attributes_ module that allows setting remote attributes mapping to user fields.
This PR adds the bundle to the first/last name fields.
As a note, fields added through the UI and saved into configuration do have the bundle set to "user", however, fields added through
hook_entity_base_field_info_alter()do not (even if using->setTargetBundle('user')), I think that because by definition base fields apply to all bundles of an entity type.