-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#393] Drupal 9 deprecations fixes #397
Conversation
10b512a
to
987d25f
Compare
987d25f
to
02cdf12
Compare
@cnovak Is this PR going to create a new major version form the module? There are quite some changes on the public API or the module (like new menthods in interfaces, changed return types) that could break downstream projects that were using these. What is the strategy for supporting Drupal 8.x and Drupal 9.x when Drupal 9.0.0 it is out? |
… getLowercaseLabel().
… getLowercaseLabel().
…8 only - no rules for D9 yet.
d1a493a
to
542c48a
Compare
@mxr576 We have discussed creating a new 2.x branch that supports both D8 and D9. However, I have updated the PR and I think there are no breaking changes any more.
Testing |
Instead of |
Good catch @kscheirer ! I have updated the PR to use multibyte functions where user input is processed. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Thanks @arlina-espinoza
Re. the singular label/lowercase deprecation, I think we should make the change so that label_singular
annotation on the entity type is lowercase. This is how core does it: https://git.drupalcode.org/project/drupal/-/commit/13822906e5d7704a0df00dbd930b09a71f4b1972
See also \Drupal\Core\Entity\EntityTypeInterface::getSingularLabel
/**
* Gets the indefinite singular form of the name of the entity type.
*
* This should return the human-readable name for a single instance of
* the entity type. For example: "opportunity" (with the plural as
* "opportunities"), "child" (with the plural as "children"), or "content
* item" (with the plural as "content items").
*
* Think of it as an "in a full sentence, this is what we call this" label. As
* a consequence, the English version is lowercase.
*
* @return string|\Drupal\Core\StringTranslation\TranslatableMarkup
* The singular label.
*/
public function getSingularLabel();
@arlina-espinoza Thanks. LGTM. |
Makes
apigee_edge
module and submodules compatible with Drupal 9, as checked with the deprecation checker toolmglaman/drupal-check
.