Copy changes for general settings

[cnovak]

• Copy changes to general settings
• Change default name of “developer apps” to “apps”
• “Apigee Edge” should not be shortened to “Edge”
• Remove custom styling of developer sync page, change to match cron form
• Removed “please” from copy
• Page titles should only have first work capitalized

[mxr576]

Please use the #html_tag render element instead if this really needs to wrapped in <p> tag. Is it?

https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Render%21Element%21HtmlTag.php/class/HtmlTag/8.5.x

[cnovak]

@mxr576 I followed the same pattern for description that the Cron form uses:

 /**
   * {@inheritdoc}
   */
  public function buildForm(array $form, FormStateInterface $form_state) {
    $form['description'] = [
      '#markup' => '<p>' . t('Cron takes care of running periodic tasks like checking for updates and indexing content for search.') . '</p>',
    ];
    $form['run'] = [
      '#type' => 'submit',
      '#value' => t('Run cron'),
      '#submit' => ['::runCron'],
    ];

The code and other forms are following this format, so if we don't put description in

the page may style differently than other pages. Let me know if you still think we should change this code to use #html_tag render element. I think we should stay with the pattern other admin forms are using.

[cnovak]

Talked to @mxr576 , will still wrap in

like other modules, but use #html_tag render element for more flexibility.

[mxr576]

Little nitpicking, but single method call should be in the same line, parameter list could be in multiple lines if it is necessary, otherwise, PR looks fine.

[mxr576]

@cnovak Please monitor your Travis builds after you created a new PR every time. It was quite clear that your code changes introduced a new a coding style violation: https://travis-ci.org/cnovak/apigee-edge-drupal/builds/399633201

As a general practice I'd like to ask all developers to submit their Travis build in the URL of their PR so we could easily check whether their build is passing or not. The apigee/apigee-edge-drupal Travis CI is only checking code style, but it does not run tests with active Apigee Edge connection.

[mxr576]

@cnovak Some tests are starting to get failed on your Travis after I have fixed the code style: https://travis-ci.org/cnovak/apigee-edge-drupal/jobs/399868817#L1173

[mxr576]

Failing tests on Travis should be fixed.

[cnovak]

I ran the build again after changing connection settings to fix the failed build, and still getting errors:

Caused by
Apigee\Edge\Exception\ClientErrorException: Forbidden

Not much info to go on. What needs to be done to troubleshoot this error?

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

[mxr576]

@cnovak would you like to update this PR or can we close this?

[cnovak]

I need to finish this in this sprint. Still having an issue where password is getting modified to something different using environment variables. I debugged locally and could see it was being changed but did not have a chance to figure out why.

[peterserfozo]

@cnovak It seems your credentials are wrong in Travis. Try to delete APIGEE_EDGE_USERNAME and APIGEE_EDGE_PASSWORD (https://travis-ci.org/cnovak/apigee-edge-drupal/settings) and set the values again for these environment variables surrounded by double quotes (") then restart the latest build.

[cnovak]

Going to resubmit this PR after merging