[#339] Add a pagination fallback method in case call with "expand=true" fails. #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing since this fix did not help customer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #339.
It updates the listing method of the controller, so that if a call with
expand=truefails (the default way to load all entities), it would retry fetching that page with just it's IDs (expand=false), and then loading each entity individually.As mentioned in the issue comments, it is definitively not as performant, but it a solution to an edge case, and should allow showing all of the other entities (API products in the case of issue #339), while logging the errors in watchdog for both the
expand=truecall and the failed entity load call.It should work, assuming the call with
expand=falseworks.