Replace Travis CI with CircleCI #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadcn
approved these changes
Feb 21, 2020
There was a problem hiding this comment.
Woah this is a major DX win @arlina-espinoza Thank you. LGTM 👍
Do we have follow up tickets for "To do after this PR: Enable kernel kernel, functional and JS tests - fix any tests that aren't passing."?
cnovak
requested changes
Feb 24, 2020
Added follow up issue to enable other tests here: #341 @cnovak I've addressed the requested changes, could you review again, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the Travis CI integration with CircleCI. Currently only runs the code sniffer - the same job that is running in travis (kernel, functional and JS tests are commented out for now).
To do after this PR: Enable kernel kernel, functional and JS tests - fix any tests that aren't passing.