Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#156] Display expired credentials #290

Merged
merged 4 commits into from
Nov 7, 2019
Merged

[#156] Display expired credentials #290

merged 4 commits into from
Nov 7, 2019

Conversation

shadcn
Copy link
Contributor

@shadcn shadcn commented Oct 31, 2019

Fixes #156

This PR displays expired credentials on the app page under key status and adds a warning on the app listing page for expired credentials.

ac-test-app-for-expired_app___Apigee

Apps___Apigee

@googlebot googlebot added the cla: yes Indicates CLA has been signed label Oct 31, 2019
mxr576
mxr576 suggested changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@mxr576 mxr576 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA: Replace intval() with typecasting (int) in the modified functions.

src/Entity/ListBuilder/AppListBuilder.php Outdated Show resolved Hide resolved
apigee_edge.module Outdated Show resolved Hide resolved
src/Entity/ListBuilder/AppListBuilder.php Outdated Show resolved Hide resolved
kscheirer
kscheirer reviewed Oct 31, 2019
View reviewed changes
apigee_edge.module Outdated Show resolved Hide resolved
@mxr576 mxr576 mentioned this pull request Nov 5, 2019
Closed
kscheirer
kscheirer approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@kscheirer kscheirer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor question

src/Entity/ListBuilder/AppListBuilder.php Show resolved Hide resolved
@shadcn shadcn merged commit fd8188b into apigee:8.x-1.x Nov 7, 2019
@shadcn shadcn mentioned this pull request Nov 20, 2019
Closed
@arlina-espinoza arlina-espinoza added this to the 8.x-1.3 milestone Dec 4, 2019
@cnovak cnovak mentioned this pull request May 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxr576 mxr576 mxr576 requested changes

@kscheirer kscheirer kscheirer approved these changes

@arunz6161 arunz6161 Awaiting requested review from arunz6161

@arlina-espinoza arlina-espinoza Awaiting requested review from arlina-espinoza

@minnur minnur Awaiting requested review from minnur

Assignees
No one assigned
Labels
cla: yes Indicates CLA has been signed
Projects
None yet
Milestone
8.x-1.3
Development

Successfully merging this pull request may close these issues.

DRUP-667 Display expired credentials as such
5 participants
@shadcn @kscheirer @mxr576 @arlina-espinoza @googlebot